Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several failures. #163

Merged
merged 16 commits into from
Mar 26, 2022
Merged

Conversation

ericsnowcurrently
Copy link
Member

A few bugs have crept in with some of my recent changes. Part of the problem is that there hasn't been great test coverage for a bunch of pyperformance code. In this PR I've added a bunch of testing. I've also fixed a number of problems.

@ericsnowcurrently ericsnowcurrently merged commit c2b4a28 into python:main Mar 26, 2022
@ericsnowcurrently ericsnowcurrently deleted the fix-failures branch March 26, 2022 06:22
@gvanrossum
Copy link
Member

I wonder how much of my Windows woes this fixes? I'll give it a try. @ericsnowcurrently please note that I accidentally pushed a change to greenlet==2.0.0a2. I meant to create a PR but due to my git clumsiness pushed to main. Sorry. But I think it's the right fix, so I hope we can keep it.

@ericsnowcurrently
Copy link
Member Author

I wonder how much of my Windows woes this fixes? I'll give it a try.

+1

@ericsnowcurrently please note that I accidentally pushed a change to greenlet==2.0.0a2. I meant to create a PR but due to my git clumsiness pushed to main. Sorry. But I think it's the right fix, so I hope we can keep it.

No worries.

@gvanrossum
Copy link
Member

I still have four failing benchmarks on Windows:

  • dulwich_log
  • genshi
  • sqlalchemy_declarative
  • sqlalchemy_imperative

The other failures I had were due to the broken --python flag (#107). I also still have the psutil issue (#148).

The biggest mystery is greenlet (the failing dependency for the sqlalchemy benchmarks), for which I can make the install pass by causing a cached wheel to appear in pip's cache. I do that by running the following in the cpython repo (whose binary is also the one I use to run the benchmarks):

.\python.bat -m pip cache purge
.\python.bat -m pip uninstall greenlet==2.0.0a2
.\python.bat -m pip install greenlet==2.0.0a2

@brandtbucher
Copy link
Member

Just a note: you can use the --no-cache-dir option to ignore cached wheels, and --force-reinstall to skip the uninstall step. So...

.\python.bat -m pip install --no-cache-dir --force-reinstall greenlet==2.0.0a2

...should do it in one command.

@gvanrossum
Copy link
Member

Remembering those options might be harder than the original steps. :-)

Let's continue the discussion in faster-cpython/ideas#333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants