-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several failures. #163
Fix several failures. #163
Conversation
I wonder how much of my Windows woes this fixes? I'll give it a try. @ericsnowcurrently please note that I accidentally pushed a change to greenlet==2.0.0a2. I meant to create a PR but due to my git clumsiness pushed to main. Sorry. But I think it's the right fix, so I hope we can keep it. |
+1
No worries. |
I still have four failing benchmarks on Windows:
The other failures I had were due to the broken The biggest mystery is greenlet (the failing dependency for the sqlalchemy benchmarks), for which I can make the install pass by causing a cached wheel to appear in pip's cache. I do that by running the following in the cpython repo (whose binary is also the one I use to run the benchmarks):
|
Just a note: you can use the
...should do it in one command. |
Remembering those options might be harder than the original steps. :-) Let's continue the discussion in faster-cpython/ideas#333 |
A few bugs have crept in with some of my recent changes. Part of the problem is that there hasn't been great test coverage for a bunch of pyperformance code. In this PR I've added a bunch of testing. I've also fixed a number of problems.