Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QHC-587] Enable setting markers for QProgram + Qblox #747

Merged
merged 14 commits into from
Jul 10, 2024
Merged

[QHC-587] Enable setting markers for QProgram + Qblox #747

merged 14 commits into from
Jul 10, 2024

Conversation

fedonman
Copy link
Collaborator

@fedonman fedonman commented Jul 3, 2024

No description provided.

@linear Linear
Copy link

linear bot commented Jul 3, 2024

QHC-587 Enable markers usage in QProgram.

@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.95%. Comparing base (a0f668d) to head (88e8c24).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
+ Coverage   94.92%   94.95%   +0.02%     
==========================================
  Files         262      263       +1     
  Lines        8540     8589      +49     
==========================================
+ Hits         8107     8156      +49     
  Misses        433      433
Flag Coverage Δ
unittests 94.95% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jjmartinezQT
jjmartinezQT approved these changes Jul 3, 2024
View reviewed changes
docs/releases/changelog-dev.md Show resolved Hide resolved
tests/qprogram/test_qblox_compiler.py Show resolved Hide resolved
jordivallsq
jordivallsq approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@jordivallsq jordivallsq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!!! I could not see any mistake, let's wait for Adrian test and then que can merge this into main.

jordivallsq
jordivallsq reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@jordivallsq jordivallsq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements!!, I added some silly questions and apart from that we should try the new code with Adri

docs/releases/changelog-dev.md Show resolved Hide resolved
src/qililab/instruments/qblox/qblox_module.py Show resolved Hide resolved
src/qililab/instruments/qblox/qblox_module.py Show resolved Hide resolved
src/qililab/qprogram/qblox_compiler.py Outdated Show resolved Hide resolved
src/qililab/qprogram/qblox_compiler.py Show resolved Hide resolved
fedonman
fedonman commented Jul 10, 2024
View reviewed changes
Copy link
Collaborator Author

@fedonman fedonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed all comments, I will merge this.

docs/releases/changelog-dev.md Show resolved Hide resolved
@jjmartinezQT jjmartinezQT merged commit 75b5085 into main Jul 10, 2024
6 checks passed
@jjmartinezQT jjmartinezQT deleted the qhc-587-enable-markers-usage-in-qprogram branch July 10, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordivallsq jordivallsq jordivallsq approved these changes

@jjmartinezQT jjmartinezQT Awaiting requested review from jjmartinezQT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedonman @jjmartinezQT @jordivallsq