added filters on the runcard #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ets-mapped-to-qm-driver
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
=======================================
Coverage 95.02% 95.02%
=======================================
Files 266 266
Lines 8724 8724
=======================================
Hits 8290 8290
Misses 434 434
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ets-mapped-to-qm-driver
…ets-mapped-to-qm-driver
GuillermoAbadLopez
requested changes
Aug 7, 2024
src/qililab/instruments/quantum_machines/quantum_machines_cluster.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Guillermo Abad López <109400222+GuillermoAbadLopez@users.noreply.github.com>
|
Adressed all the comments |
GuillermoAbadLopez
approved these changes
Aug 7, 2024
…ets-mapped-to-qm-driver
|
The filters have been tested in QM OPX and the results look the same as the ones measured by Mireia. Before filters: After filters: |
jordivallsq
deleted the
qhc-634-distortion-coefficients-in-runcard-gets-mapped-to-qm-driver
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created filters in the controlers section of QUA config