Implemented delay qblox qprogram #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
=======================================
Coverage 95.87% 95.88%
=======================================
Files 273 273
Lines 9003 9024 +21
=======================================
+ Hits 8632 8653 +21
Misses 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ithub.com/qilimanjaro-tech/qililab into qhc-725-implement-initial-delays-in-qblox
jjmartinezQT
requested changes
Sep 9, 2024
jjmartinezQT
approved these changes
Sep 9, 2024
jjmartinezQT
pushed a commit
that referenced
this pull request
Sep 10, 2024
* Implemented delay qblox qprogram * REMOVED READOUT CONDITION DELAY * Modified sync to take de,ay into account * removed mandatory delay from awg_sequencers * Black * added missing tests * test fix * fixed tests * tests * aDDED NEGATIVE DELAYS * pylint * pylint * Update qblox_compiler.py * Update qblox_compiler.py * Update qblox_compiler.py
jjmartinezQT
added a commit
that referenced
this pull request
Sep 10, 2024
* changelog * changelog * Implemented delay qblox qprogram (#793) * Implemented delay qblox qprogram * REMOVED READOUT CONDITION DELAY * Modified sync to take de,ay into account * removed mandatory delay from awg_sequencers * Black * added missing tests * test fix * fixed tests * tests * aDDED NEGATIVE DELAYS * pylint * pylint * Update qblox_compiler.py * Update qblox_compiler.py * Update qblox_compiler.py * added changelog (#795) * including label for variable * arguments fixed * fixing unittest * num_averages is more explicit * unittest * reducing number variables in test pylint * avoiding pylint * code quality * proper pylint code --------- Co-authored-by: GitHub Actions bot <actions@github.com> Co-authored-by: jordivallsq <151619025+jordivallsq@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.