Allow getCells to populate Connections

[davidfig]

• replace {{x, y, sheetName?}} in connection query with the value at that location
• show an error if the sheet name does not exist
• update cells_accessed with all get cell calls
• allow inserting cells with a button in the connection editor
• support relative references
• show cursor when code editor loses focus (not perfect yet)
• cell accessed highlighting

[qa-wolf]

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
quadratic	✅ Ready (Inspect)	Visit Preview	Sep 17, 2024 3:53pm

[codecov]

Codecov Report

Attention: Patch coverage is 98.40637% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.99%. Comparing base (46ac83c) to head (c901dac).
Report is 539 commits behind head on qa.

Files with missing lines	Patch %	Lines
...rc/controller/execution/run_code/run_connection.rs	98.72%	3 Missing ⚠️
quadratic-core/src/error_run.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               qa    #1791      +/-   ##
==========================================
+ Coverage   90.95%   90.99%   +0.04%     
==========================================
  Files         220      220              
  Lines       46068    46308     +240     
==========================================
+ Hits        41902    42139     +237     
- Misses       4166     4169       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[luke-quadratic]

This is rly awesome - no bugs found running through basic tests of feature

[davidkircos]

@davidfig is this safe from SQL injection?

[davidfig]

No, not yet. It's a much worse experience b/c the library requires that we know the types.

For our current implementation and permissions, any user who has access to the SQL doesn't need injection since they already have full ability to change the SQL. In the future, when we allow users to run pre-existing SQL but not change the SQL (but they can change values that feed into the SQL), then we will need to be much better about injection protections.

[davidkircos]

@davidfig looks great to me! Fix merge conflicts and it's good to go

[davidkircos]

Blocked by waiting for switch to A1