Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename PythonError to CodeRunError #1902

Open
wants to merge 7 commits into
base: qa
Choose a base branch
from

Conversation

AyushAgrawal-A2
Copy link
Collaborator

@AyushAgrawal-A2 AyushAgrawal-A2 commented Sep 21, 2024

Changes:

  • Renames PythonError -> CodeRunError in sheet and in file v1_7

Copy link

qa-wolf bot commented Sep 21, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Sep 21, 2024
Copy link

vercel bot commented Sep 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ❌ Failed (Inspect) Oct 3, 2024 0:16am

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1902 September 21, 2024 14:41 Inactive
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 34.07821% with 236 lines in your changes missing coverage. Please review.

Project coverage is 91.11%. Comparing base (b41c6d9) to head (4dbccd1).
Report is 109 commits behind head on qa.

Files with missing lines Patch % Lines
...dratic-core/src/grid/file/v1_7/run_error_schema.rs 12.57% 153 Missing ⚠️
quadratic-core/src/grid/file/v1_6/file.rs 53.52% 79 Missing ⚠️
...atic-core/src/controller/execution/run_code/mod.rs 0.00% 2 Missing ⚠️
quadratic-core/src/grid/file/v1_5/run_error.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #1902      +/-   ##
==========================================
- Coverage   91.52%   91.11%   -0.41%     
==========================================
  Files         242      243       +1     
  Lines       53926    54275     +349     
==========================================
+ Hits        49355    49452      +97     
- Misses       4571     4823     +252     
Flag Coverage Δ
91.11% <34.07%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from ayush/remove_clones to borders-rework September 24, 2024 10:45
Base automatically changed from borders-rework to qa September 27, 2024 16:50
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1902 September 30, 2024 05:03 Inactive
@davidkircos davidkircos added the QA bug exists in QA branch, not prod label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed QA bug exists in QA branch, not prod status: ready for user test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants