Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preprocess allowed_symbols #247

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Fix preprocess allowed_symbols #247

merged 3 commits into from
Nov 28, 2023

Conversation

derNarr
Copy link
Member

@derNarr derNarr commented Nov 28, 2023

Fixes #245 .

Changes proposed in this pull request:

  • removes the wrong documentation
  • adds a special value for all symbols ("all"), which is also the default
  • removes the old default, which leads to no allowed symbols

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (be6c481) 83.75% compared to head (e4ac99f) 83.65%.

Files Patch % Lines
pyndl/preprocess.py 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
- Coverage   83.75%   83.65%   -0.11%     
==========================================
  Files           9        9              
  Lines        1410     1413       +3     
==========================================
+ Hits         1181     1182       +1     
- Misses        229      231       +2     
Flag Coverage Δ
unittests 83.65% <33.33%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derNarr derNarr merged commit 23463a3 into main Nov 28, 2023
8 checks passed
@derNarr derNarr deleted the fix-preprocess branch November 28, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mistake in documentation of create_event_file
3 participants