Docker build failure - Add Tini and set version range for numpy

[fzagarzazu]

First time user, I spent some time setting it up and I ran into a few issues, the purpose of this pull request is to bring it to your attention, maybe it will help somebody else. Please close it if it doesn't apply.

Background:

• First time user.
• OS X El Capitan + VirtualBox
• Docker version 1.9.1,

Docker build failure:

Obtaining file:///zipline
    Complete output from command python setup.py egg_info:
    warning: no files found matching '*.pyx' under directory 'Cython/Debugger/Tests'
    warning: no files found matching '*.pxd' under directory 'Cython/Debugger/Tests'
    warning: no files found matching '*.h' under directory 'Cython/Debugger/Tests'
    warning: no files found matching '*.pxd' under directory 'Cython/Utility'
    Unable to find pgen, not compiling formal grammar.

    Installed /zipline/.eggs/Cython-0.24.1-py2.7-linux-x86_64.egg
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/zipline/setup.py", line 300, in <module>
        **conditional_arguments
      File "/usr/local/lib/python2.7/distutils/core.py", line 111, in setup
        _setup_distribution = dist = klass(attrs)
      File "/usr/local/lib/python2.7/site-packages/setuptools/dist.py", line 315, in __init__
        self.fetch_build_eggs(attrs['setup_requires'])
      File "/usr/local/lib/python2.7/site-packages/setuptools/dist.py", line 361, in fetch_build_eggs
        replace_conflicting=True,
      File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 851, in resolve
        dist = best[req.key] = env.best_match(req, ws, installer)
      File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1116, in best_match
        dist = working_set.find(req)
      File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 720, in find
        raise VersionConflict(dist, req)
    pkg_resources.VersionConflict: (numpy 1.9.2 (/usr/local/lib/python2.7/site-packages), Requirement.parse('numpy>=1.11.1'))

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /zipline/

Possible solution / workaround:

• Set numpy version range. (included in commit).

Jupyter notebooks: Dead kernels / automatic restart failures.

• Please see Dead kernels in docker IPython notebook server ipython/ipython#7062 for details.
• Possible solution: Add Tini - https://github.com/krallin/tini. (included in commit).

Thank you for your work.

[coveralls]

Coverage remained the same at 86.55% when pulling 68f6e6e on fzagarzazu:fix-dockerfile into be0ecb6 on quantopian:master.

[lssilva]

Thank you I had the same issue, I hope this is integrated soon

[ssanderson]

Had one request and one question, otherwise looks reasonable to me.

[ssanderson]

Latest zipline is also on pandas 0.18.1 and scipy 0.17.1 if you want to bump those as well.

[fzagarzazu]

Good point, latest commit sets the version range for pandas and scipy.

[fzagarzazu]

Please note I added && pip install matplotlib \ to the Dockerfile in order to fix an error when executing zipline/examples/buyapple.ipynb .

[ssanderson]

Is there a good executive summary somewhere of the benefits of using tini as the container pid 1? I'm aware vaguely that it solves issues with zombie processes not being correctly reaped, but I don't have a clear sense of concrete cases where it fixes issues.

[fzagarzazu]

I didn't dig much into it, but this is the best explanation I found krallin/tini#8 .

[fzagarzazu]

For what it's worth I am running it with docker-compose .

[coveralls]

Coverage decreased (-0.006%) to 86.544% when pulling 4ae4934 on fzagarzazu:fix-dockerfile into be0ecb6 on quantopian:master.

[ssanderson]

👍, thanks @fzagarzazu!