Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typst brand yaml: typography bells and whistles #10974

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gordonwoodhull
Copy link
Contributor

@gordonwoodhull gordonwoodhull commented Oct 4, 2024

This is in good shape and has basic test coverage for all supported feature-element combinations.

image

Also includes support for subtitles in typst, taking @mcanouil's contribution to the Pandoc template from upstream #9638, and styling it as a heading.

Leaving this as a draft for now because although I'd be happy merging this in its current state, there are a few last touches to make:

  • Remove less-useful feature-element combinations listed in https://github.com/posit-dev/brand-yml/issues/16#issuecomment-2344394279
  • Typst brand.typography should allow use of named colors from brand.color for color, background-color
  • Support rem correctly when brand.typography.base.size is specified. Current blind change to em will be the fallback with a warning when base.size is unknown
  • Translation of CSS padding and width for logo - currently one must use Typst-compatible units.
  • Refactor CSS->Typst translation functions to a module used by typst brand yaml and typst css

weight
style
size
decoration
color
background-color
line-height
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant