Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): add role="list" to QList (fix: #17439) #17441

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

Evertvdw
Copy link
Contributor

I also added some tests for the QList component. The QItem role="listitem" should be similarly conditional when using li as a tag, because then the listitem role is not necessary. But that could be a next PR.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

Copy link

github-actions bot commented Aug 16, 2024

UI Tests Results

    1 files     98 suites   38s ⏱️
1 031 tests 1 031 ✅ 0 💤 0 ❌
1 050 runs  1 050 ✅ 0 💤 0 ❌

Results for commit db8e1ca.

♻️ This comment has been updated with latest results.

Copy link
Member

@yusufkandemir yusufkandemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nicely done. I have some small suggestions.

ui/src/components/item/QList.test.js Outdated Show resolved Hide resolved
ui/src/components/item/QList.js Outdated Show resolved Hide resolved
Evertvdw and others added 2 commits August 16, 2024 18:31
Co-authored-by: Yusuf Kandemir <yusuf.kandemir@outlook.com.tr>
Co-authored-by: Yusuf Kandemir <yusuf.kandemir@outlook.com.tr>
@yusufkandemir yusufkandemir changed the title fix(a11y): Add role="list" on the list #17439 fix(ui): add role="list" to QList (fix: #17439) Aug 16, 2024
@yusufkandemir yusufkandemir merged commit a0b7171 into quasarframework:dev Aug 16, 2024
3 checks passed
@yusufkandemir
Copy link
Member

Thanks for contributing, will be available in the next quasar release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants