refactor: Upgrade opendal to v0.47.0 for zero copy bytes streaming #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
changed the title
Xuanwo
commented
Jun 11, 2024
| @@ -198,7 +198,7 @@ rdkafka = { version = "0.33", default-features = false, features = [ | |||
| ] } | |||
| regex = "1.10.0" | |||
| regex-syntax = "0.8" | |||
| reqwest = { version = "0.11", default-features = false, features = [ | |||
| reqwest = { version = "0.12", default-features = false, features = [ | |||
There was a problem hiding this comment.
OpenDAL uses reqwest 0.12 (along with http 1.0, hyper 1.0) now. Maybe I can make more PRs to help migrating other crates?
There was a problem hiding this comment.
We're still waiting on tonic to move to hyper 1.0.
There was a problem hiding this comment.
Got it. Let's wait for hyperium/tonic#1670
There was a problem hiding this comment.
Hi, @guilload maybe this PR is happy to go?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade opendal to v0.47.0 for zero copy bytes streaming
How was this PR tested?
Unit test and integration tests.