Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Add IPFS machine backend #381

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Add IPFS machine backend #381

merged 1 commit into from
Jan 15, 2019

Conversation

geigerzaehler
Copy link

@geigerzaehler geigerzaehler commented Jan 11, 2019

  • Add a MachineBackend implementation based on IPFS
  • Extend test/machine-backends.rad to test IPFS backend against real IPFS daemon
  • Add commands rad-ipfs, rad-ipfs-daemon, and rad-ipfs-machine-create

Follow-up

package.yaml Outdated Show resolved Hide resolved

-- | Given a CID @"abc...def"@ it returns a IPLD link JSON object
-- @{"/": "abc...def"}@.
ipldLink :: CID -> Aeson.Value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be nice to have in oscoin/ipfs somewhere

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed. There is a couple of things we should backport, like the response types.

@xla xla changed the title [wip] IPFS [WIP] IPFS Jan 14, 2019
@geigerzaehler geigerzaehler changed the title [WIP] IPFS Add IPFS machine backend Jan 15, 2019
- multibase
- multihash-cryptonite

flags:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang. bump monadic-xyz/ipfs#7

deriving (Show, Eq)

instance Exception IpfsException where
displayException (IpfsException msg) = "ipfs: " <> toS msg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL displayException is a thing

Copy link
Contributor

@kim kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jameshaydon jameshaydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

* Add a `MachineBackend` implementation based on IPFS
* Extend `test/machine-backends.rad` to test IPFS backend against real
  IPFS daemon
* Add commands `rad-ipfs`, `rad-ipfs-daemon`, and
`rad-ipfs-machine-create`

Follow-up

* Replace `Wreq` with `servant-client` and `ipfs-api` from
  https://github.com/oscoin/ipfs/tree/master/ipfs-api
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants