Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3: Bug with LabeledSelect with "multiple" attribute #12117

Open
aalves08 opened this issue Oct 3, 2024 · 1 comment · Fixed by #12129
Open

Vue3: Bug with LabeledSelect with "multiple" attribute #12117

aalves08 opened this issue Oct 3, 2024 · 1 comment · Fixed by #12129
Assignees
Labels
area/vue3 kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@aalves08
Copy link
Member

aalves08 commented Oct 3, 2024

Setup

  • Rancher version: Any + Vue3 frontend
  • Rancher UI Extensions:
  • Browser type & version:

Describe the bug

Using LabeledSelect with option multiple="true" is not working properly

To Reproduce

  • Create some secrets of type kubernetes.io/dockercfg (at least a couple)
  • Create Registry Secret if missing
  • Go to Deployments -> Create -> go to the Pull Secrets select on the General tab and select an option

Result

  • Throws an error

Expected Result

  • Should work fine

Screenshots

Vue3 (fails)
https://github.com/user-attachments/assets/ede5a1ec-432a-4ba9-9562-1131ca6b5276

2.9-head (works)
https://github.com/user-attachments/assets/52ba106a-4e41-4921-8dca-515210b9d017

Additional context

I believe it's related to the option multiple="true"
https://vue-select.org/guide/values.html#single-multiple

If we add the attribute multiple to the v-select, the output is an array and it works fine, so the binding of the attributes is where the problem lies

@aalves08 aalves08 added this to the v2.10.0 milestone Oct 3, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Oct 3, 2024
@cnotv cnotv self-assigned this Oct 4, 2024
@aalves08 aalves08 self-assigned this Oct 4, 2024
@cnotv
Copy link
Contributor

cnotv commented Oct 4, 2024

Note: This issue seems a recent regression since I had to pull master to reproduce it.

EDIT: Found regression: #11954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vue3 kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants