Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug with LabeledSelect with "multiple" attribute #12129

Merged

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Oct 4, 2024

Summary

Fixes #12117

Occurred changes and/or fixed issues

  • fix issue with LabeledSelect in mode multiple by allowing the binding of the attribute to the element v-select that was incorrectly being filtered out

Technical notes summary

Areas or cases that should be tested

  • Test repro case(s) in issue + test some other areas that use LabeledSelect with multiple="true"

Areas which could experience regressions

  • Just to discard any regressions, do a quick test of different instances of LabeledSelect, even if they don't use multiple="true"

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 self-assigned this Oct 4, 2024
@aalves08 aalves08 added this to the v2.10.0 milestone Oct 4, 2024
@cnotv
Copy link
Contributor

cnotv commented Oct 4, 2024

I am not so sure this is the whole issue here. When I searched for other cases, I could not reproduce them equally. Investigating the issue specifically, resulted in trying to map a string of the term:

Screenshot 2024-10-04 at 12 51 50

In your PR this issue is fixed, although I suspect there's something further around the attributes clashing here.

Screenshot 2024-10-04 at 12 54 39

For the sake of solving the issue, we can ignore the attribute inheritance confusion, although we should bare mind.

@cnotv
Copy link
Contributor

cnotv commented Oct 4, 2024

I've added a unit test that seems to validate the behavior change from string to array in case of multiple.
The other case has a different event handler which is not a bidirectional binding.

@cnotv cnotv force-pushed the 12117-fix-issue-multiple-labeled-select branch from 16824db to 1fba36c Compare October 4, 2024 13:39
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Storybook seems not achievable atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue3: Bug with LabeledSelect with "multiple" attribute
2 participants