update ec2 instances list in amazon.js #5178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to SURE-5089. My use case is really just to try and save a little money by using AMD instances but once I got started on making the change I saw there was a long list of instance types that probably should be included. |
|
+1 here, also need this |
|
It looks like you want to update the list of instances available in the EKS provisioning form specifically: that list should be updated in Rancher 2.9 onwards (we are also updating that data dynamically from an AWS api now so you shouldn't have to keep updating Rancher to get fresh options). This PR will however update the list of ec2 options shown in the RKE1 provisioning form so it'd still be nice to get in 2.10. Thanks for submitting this @tp-drosssmith
|
mantis-toboggan-md
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the included AWS EC2 instance list in Rancher is a bit stale. I've attempted to update the existing instance types with the latest Intel/AMD versions excluding some of the fancier EC2 types for networking/storage . Graviton instances look like they're still marked as "experimental" for use in Rancher so those have been excluded too.