Add unit tests and comments to the name package #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsokolovsky
requested changes
Apr 30, 2024
JonCrowther
force-pushed
the
improve-name-package
branch
from
1c9388a
to
ef85490
Compare
maxsokolovsky
approved these changes
May 1, 2024
tomleb
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor tech debt. Add comments to each of the exported functions. A lot of these functions are not great (would prefer to return errors), but since they're exported we should at minimum provide comments.
I added some unit tests to
SafeConcatNamebecause I've used it extensively elsewhere so I want to make sure it doesn't get broken accidentally.