Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major rework of command submission + task events #359

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Conversation

rdaum
Copy link
Owner

@rdaum rdaum commented Jul 10, 2024

Rework the $do_command -> parse command cycle

  • Moves the logic for running $do_command out of the RpcServer and
    into the task itself.
  • It's a big gronky, but I wrote tests. And the tests pass.
  • Removed the blocking watch command piece from rpc_server.rs, so
    another means is going to be necessary for reporting failures back
    to the host.
  • Major reworking of the RPC layer to handle async events:
    • Errors from task submissions are now handled asynchronously,
      published out to clients as they complete, rather than blocking
      the rpc server (& telnet connection)
    • "narrative" pubsub stream now becomes "events", more generic
    • Moved SchedulerError and friends up into model, & cleaned up the
      Rpc error enum to use that instead of duplicating a bunch of
      values.
    • All tests pass, JHCore runs.

rdaum added 3 commits July 9, 2024 21:21
  * Moves the logic for running $do_command out of the `RpcServer` and
    into the task itself.
  * It's a big gronky, but I wrote tests. And the tests pass.
  * Removed the blocking watch command piece from rpc_server.rs, so
    another means is going to be necessary for reporting failures back
    to the host.
  * Errors from task submissions are now handled asynchronously,
    published out to clients as they complete, rather than blocking
    the rpc server (& telnet connection)
  * "narrative" pubsub stream now becomes "events", more generic
  * Moved SchedulerError and friends up into model, & cleaned up the
    Rpc error enum to use that instead of duplicating a bunch of
    values.
  * All tests pass, JHCore runs.
@rdaum rdaum requested a review from abesto July 10, 2024 03:17
@rdaum rdaum self-assigned this Jul 10, 2024
abesto and others added 3 commits July 10, 2024 09:10
I had moved them to `model` but that should be for the world state
stuff.

This adds a `tasks` module which exports various scheduler / task
interface related things like errors, TaskId, events
@rdaum rdaum merged commit 02ab1a9 into main Jul 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants