Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK Prepare Server Selection Issue #822

Closed
akramali86 opened this issue Nov 20, 2023 · 1 comment · Fixed by #855
Closed

SDK Prepare Server Selection Issue #822

akramali86 opened this issue Nov 20, 2023 · 1 comment · Fixed by #855
Labels
area:api Issues related to the `api` CLI, which builds the SDKs bug Something isn't working help wanted Extra attention is needed

Comments

@akramali86
Copy link

If a server is index 0 in the servers array in the generated openapi.json it is incorrectly ignored due to it being falsy. I think the issue is this line

I've managed to find a work around for now, by manually adding the same server item to the servers array therefore it being index 1.
@erunion erunion added bug Something isn't working help wanted Extra attention is needed area:api Issues related to the `api` CLI, which builds the SDKs labels Dec 3, 2023
@yoitsro
Copy link
Contributor

yoitsro commented Feb 13, 2024

This is now closed in #855

@kanadgupta kanadgupta mentioned this issue Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:api Issues related to the `api` CLI, which builds the SDKs bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure prepareServer respects server variables when custom url is the same as the OAS url
4 participants
@erunion @yoitsro @akramali86 @kanadgupta