fix: ensure prepareServer respects server variables when custom url is the same as the OAS url #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoitsro
changed the title
…s the same as the OAS url A truthy check was being performed on the `serverIdx`, which would effectively ignore the value when `serverIdx` was 0. This fixes that to ensure that server variables are respected when the server URL passed in is the same as the server URL defined in the OAS.
kanadgupta
added
the
area:core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
A truthy check was being performed on the
serverIdx, which would effectively ignore the value whenserverIdxwas 0.This fixes that to ensure that server variables are respected when the server URL passed in is the same as the server URL defined in the OAS.
🧬 QA & Testing
It now works for us, whereas it didn't before.