fix: issue where formData would sometimes be sent twice #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
bug
erunion
requested review from
a team,
Dashron and
domharrington
and removed request for
a team
erunion
commented
Feb 3, 2022
| @@ -131,6 +132,7 @@ module.exports = async (operation, body, metadata) => { | |||
| // as a metadata object and organize into parameters. | |||
| // eslint-disable-next-line no-param-reassign | |||
| metadata = body; | |||
| metadataIntersected = true; | |||
There was a problem hiding this comment.
Open to suggestions on a better variable name than this. Basically I just need to know when body was copied to metadata, where what the user sent was a metadata object but since they didn't send a body, and body is the first argument to an operation we need to rewrite it a bit.
It's confusing I know and I'm not explaining it properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This resolves a bug I discovered in #380 where if you sent only a metadata object to an
x-www-form-urlencodedopration we'd copy that metadata over to being theformDataobject, ultimately potentially things like path parameters in the body payload.🧬 QA & Testing
See the test I added for this and the test I updated that had this incorrect behavior as an expectation. Oops.