Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: moving api-core back into the main api package #409

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

erunion
Copy link
Member

@erunion erunion commented Mar 8, 2022

🧰 Changes

Moving the core fetching logic in api into a separate package was an ill-advised idea that was only making the new CLI work a bit more complicated with the documented form-data-encoder TS issues.

This moves it back into its original home under a new core/ directory in src/.

@erunion erunion added refactor Issues about tackling technical debt area:api Issues related to the `api` CLI, which builds the SDKs labels Mar 8, 2022
@erunion erunion merged commit 8ce96f5 into main Mar 8, 2022
@erunion erunion deleted the feat/move-core-back branch March 8, 2022 20:32
@erunion erunion added this to the v5 milestone Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Issues related to the `api` CLI, which builds the SDKs refactor Issues about tackling technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant