feat: adding support for cookies in snippets #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
enhancement
erunion
commented
Mar 22, 2022
|
|
||
| delete queryParams[param]; |
There was a problem hiding this comment.
Not sure why I was doing this hokey property deletion stuff instead of just setting directly to metadata... 🤷
erunion
commented
Mar 22, 2022
| @@ -32,11 +32,11 @@ | |||
| ], | |||
| "cookies": [ | |||
| { | |||
| "name": "foo", | |||
| "name": "foo-cookie", | |||
There was a problem hiding this comment.
Changed these cookie names off foo and bar because this, and the full, test have those already as parameters and api doesn't support differing parameter types that share the same name.
erunion
requested review from
a team,
kellyjosephprice,
kanadgupta,
billhimmelsbach and
Dashron
and removed request for
a team
erunion
force-pushed
the
feat/cookie-support-in-snippets
branch
from
304fcdc
to
6ebb613
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This adds support for both cookie auth and cookie parameters in
apisnippets. This work was previously added toapiin #393 but, contrary to what that PR says, snippets have never supported it.🧬 QA & Testing