fix: resolving typing issues in JS codegen #593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
createSDK
export set asexport =
in the.d.ts
file. Having it asexport default createSDK
was causing issues where the typing was expecting you to to dosdk.default.someOperation
even though the way you load the SDK doesn't require you to have to destructure it offdefault
.types.d.ts
. And yes this does work even though the file has a.d.ts
extension:🧬 QA & Testing
This is what using a CJS SDK looks like now:
What it looked like before (with
export default createSDK
in theindex.d.ts
file):