feat: deprecating the dynamic api entrypoint
#723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
commented
Sep 12, 2023
| @@ -137,72 +128,6 @@ describe('httpsnippet-client-api', () => { | |||
|
|
|||
| expect(`${code}\n`).toStrictEqual(expected); | |||
| }); | |||
|
|
|||
| it('should generate a functional snippet', async () => { | |||
There was a problem hiding this comment.
These tests used a dist of the dynamic api entrypoint. I don't really have any interest in trying to get this extremely gross (my fault) vm sandboxing work working on that so I'm deleting all this. In the future it would probably be worth fleshing out a full integration suite for all these test cases but that's all really pertinent to api and not code snippet generation.
There was a problem hiding this comment.
would be cool to have some sort of mocking framework/library for easily testing these plugins
kanadgupta
approved these changes
Sep 12, 2023
Comment on lines
-5
to
-6
| "main": "./dist/index.js", | ||
| "types": "./dist/index.d.ts", |
| @@ -137,72 +128,6 @@ describe('httpsnippet-client-api', () => { | |||
|
|
|||
| expect(`${code}\n`).toStrictEqual(expected); | |||
| }); | |||
|
|
|||
| it('should generate a functional snippet', async () => { | |||
There was a problem hiding this comment.
would be cool to have some sort of mocking framework/library for easily testing these plugins
Co-authored-by: Kanad Gupta <8854718+kanadgupta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
The dynamic, Proxy-based, variant of
apihas been really holding us back so this is the formal deprecation and removal of all code relating to it. It was a neat experimental hack that I am very proud of but it's time to move on to only supporting codegen here as all that work, and the TS type backings it offers, are far superior.Rest in peace little buddy.
fixes RM-7986