feat: moving node imports over to using the node: prefix #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
commented
Sep 14, 2023
| @@ -1,7 +1,7 @@ | |||
| import type { TSGeneratorOptions } from '../../../src/codegen/languages/typescript'; | |||
|
|
|||
| import { promises as fs } from 'fs'; | |||
There was a problem hiding this comment.
no idea why i loaded fs/promises like this. the things you find in small refactors...
erunion
commented
Sep 14, 2023
| @@ -121,7 +122,7 @@ export default class APICore { | |||
| init.signal = controller.signal; | |||
| } | |||
|
|
|||
| return fetchHar(har as any, { | |||
| return fetchHar(har as Har, { | |||
There was a problem hiding this comment.
The HAR coming out of @readme/oas-to-har is a HAR but not a full one so we need to cast this.
kanadgupta
approved these changes
Sep 15, 2023
| @@ -8,6 +8,7 @@ export default async function parseResponse<HTTPStatus extends number = number>( | |||
|
|
|||
| const responseBody = await response.text(); | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| let data: any = responseBody; | |||
There was a problem hiding this comment.
i'm guessing unknown won't fly here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This is mostly prework for the coming ESM support but this updates our Node module imports and requires to use the
node:protocol.I've also fixed few
anytypings in a number of spots that we missed.