-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: knip #730
ci: knip #730
Conversation
@@ -6,7 +6,7 @@ | |||
"build": "npx lerna run build --stream", | |||
"build-docs": "node bin/build-markdown.js", | |||
"clean": "npx lerna clean", | |||
"lint": "npm run lint:types; npm run lint:js; npm run prettier", | |||
"lint": "knip && npm run lint:types && npm run lint:js && npm run prettier", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the commands before the semicolons weren't throwing properly failed 😬
@@ -95,15 +94,6 @@ describe('httpsnippet-client-api', () => { | |||
let consoleStub; | |||
|
|||
beforeEach(async () => { | |||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did Knip find this or you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it flagged rimraf so sort of!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dang
🧰 Changes
Brings in
knip
to help us identify code/package excess.🧬 QA & Testing
Does everything pass?