Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): storage dir not being set properly #753

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix(api): storage dir not being set properly #753

merged 1 commit into from
Oct 6, 2023

Conversation

erunion
Copy link
Member

@erunion erunion commented Oct 6, 2023

🧰 Changes

Fixes a condition introduced in #746 where Storage.dir would not get set properly when we create a new .api/ directory.

@erunion erunion added bug Something isn't working area:core Issues related to `core`, which is the package that powers the SDKs at runtime labels Oct 6, 2023
@erunion erunion marked this pull request as ready for review October 6, 2023 17:49
@erunion erunion merged commit fa31dd4 into main Oct 6, 2023
5 checks passed
@erunion erunion deleted the fix/storage-dir branch October 6, 2023 17:54
kanadgupta
kanadgupta reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh ty 🫶🏽

@erunion erunion added this to the v7 milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanadgupta kanadgupta kanadgupta left review comments

Assignees
No one assigned
Labels
area:core Issues related to `core`, which is the package that powers the SDKs at runtime bug Something isn't working
Projects
None yet
Milestone
v7
Development

Successfully merging this pull request may close these issues.
2 participants
@erunion @kanadgupta