ci: cleanup #778
Merged
ci: cleanup #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
commented
Oct 20, 2023
| @@ -11,10 +11,10 @@ | |||
| "build": "tsc", | |||
| "debug:bin": "NODE_OPTIONS=--no-warnings node --loader ts-node/esm src/bin.ts", | |||
| "lint:types": "tsc --noEmit", | |||
| "prebuild": "rm -rf dist/; npm run version", | |||
| "prebuild": "rm -rf dist/ && npm run version", | |||
There was a problem hiding this comment.
semicolons are pretty problematic — if the preceding command fails then it moves onto the next one 😬
erunion
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Node v18 is bundled with npm@9 so we don't need to install it ourselves. Also did a little bit of other cleanup in our
package.jsonscripts etc.