refactor(api): refactor core to handle HAR generation for code snippets #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
refactor
kanadgupta
approved these changes
Oct 24, 2023
| @@ -84,8 +94,7 @@ export default class APICore { | |||
| } | |||
| } | |||
|
|
|||
| // @ts-expect-error `this.auth` typing is off. FIXME | |||
There was a problem hiding this comment.
turns out the problem was that i wasn't casting some numbers as a string with String()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Slightly refactors the work I did in #783 to remove our dependency on
@readme/oas-to-harinapi. Because we already depend on this library in core it's easier to have a method for generating a HAR object from the spec we're using there instead of havingoas-to-haras a full dependency inapi.Proof that this all still works: