feat(api): export SDK #856
Conversation
In some use cases, the SDK class needs to be instantiated several times. For instance, in a multi-tenancy scenario, there may be multiple instances of the same API server, but serving different data from different base URLs. In this case, we need to instantiate multiple clients with different server URLs.
There was a problem hiding this comment.
hi, thanks so much for this contribution! unfortunately when compiling TS into CJS and ESM, files with both default and non-default exports typically lead to typing issues in certain environments. we don't have great test coverage on this front quite yet unfortunately.
what if the class was the default export from a new src/sdk.ts file and the IIFE in src/index.ts imports that?1
Footnotes
|
Yeah, I saw that discussion after submitting the PR but didn't have time to sort it. Let me take a quick look at it. |
|
Here are the changes. Once they're good, I'll squash the commits down (or I guess you could do that too if required). |
kanadgupta
added
enhancement
and we'll take care of squashing when we merge, thanks! |
🧰 Changes
In some use cases, the SDK class needs to be instantiated several times.
For instance, in a multi-tenancy scenario, there may be multiple instances of the same API server, but serving different tenants' data from different base URLs. In this case, we need to instantiate multiple clients with different server URLs.
🧬 QA & Testing
The unit test fixtures have been updated accordingly to reflect that the SDK is now exported.