Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package name for ESM syntax #857

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

EugenGedroyc
Copy link
Contributor

🚥 Resolves ISSUE_ID

🧰 Changes

After "npx api install" the dependecy "@api/gkmmk":"file:.api/apis/gkmmk" was created, but not "api": "file:.api/apis/gkmmk"

🧬 QA & Testing

for ESM
I haven't tested the package fully, but I thought I'd point it out, because the way from the readme doesn't work for me

After "npx api install" the dependecy "@api/gkmmk":"file:.api/apis/gkmmk" was created, but not "api": "file:.api/apis/gkmmk"
@EugenGedroyc EugenGedroyc changed the title fix package name for ESM syntax fix: package name for ESM syntax Feb 14, 2024
packages/api/README.md Outdated Show resolved Hide resolved
@kanadgupta kanadgupta added documentation Improvements or additions to documentation area:api Issues related to the `api` CLI, which builds the SDKs labels Feb 14, 2024
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kanadgupta kanadgupta merged commit 036f95f into readmeio:main Feb 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Issues related to the `api` CLI, which builds the SDKs documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants