Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push the smallfile test results into elasticsearch server. #1984

Merged
merged 19 commits into from
May 14, 2020
Merged

Push the smallfile test results into elasticsearch server. #1984

merged 19 commits into from
May 14, 2020

Conversation

Avilir
Copy link
Contributor

@Avilir Avilir commented May 3, 2020

Results push via ripsaw (snafu) and also with some more information
directly by this test.
Also, increas the number of the samples from 1 to 3.

Signed-off-by: Avi liani alayani@redhat.com

Also, it will retrieve the previous test results and compare to current result to see if there is a regression / progression or no change.

@Avilir
Push the smallfile test results into elasticsearch server.
32f2c7e 
Results push via ripsaw (snafu) and also with some more information
directly by this test.
Also, increas the number of the samples from 1 to 3.

Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir Avilir requested a review from a team as a code owner May 3, 2020 16:35
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label May 3, 2020
@Avilir
Adding the elasticsearch module to the requirements.txt
f2e4acd 
Signed-off-by: Avi liani <alayani@redhat.com>
AviadP
AviadP reviewed May 3, 2020
View reviewed changes
ocs_ci/ocs/cluster.py Outdated Show resolved Hide resolved
AviadP
AviadP reviewed May 3, 2020
View reviewed changes
ocs_ci/ocs/cluster.py Outdated Show resolved Hide resolved
AviadP
AviadP reviewed May 3, 2020
View reviewed changes
ocs_ci/ocs/cluster.py Outdated Show resolved Hide resolved
keesturam
keesturam reviewed May 4, 2020
View reviewed changes
Copy link
Member

@keesturam keesturam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Avilir

tests/e2e/performance/test_small_file_workload.py Outdated Show resolved Hide resolved
tests/e2e/performance/test_small_file_workload.py Outdated Show resolved Hide resolved
Avilir added 2 commits May 4, 2020 09:18
@Avilir
using ocp.get() instead of run_cmd()
f0470bc 
Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir
Fix typo in name of function.
b7dc92c 
Remove one test from the suit.

Signed-off-by: Avi liani <alayani@redhat.com>
AviadP
AviadP reviewed May 4, 2020
View reviewed changes
ocs_ci/ocs/ocp.py Outdated Show resolved Hide resolved
@Avilir
Replace run_cmd commands with ocp.get
291f966 
Signed-off-by: Avi liani <alayani@redhat.com>
ebenahar
ebenahar reviewed May 4, 2020
View reviewed changes
ocs_ci/ocs/cluster.py Outdated Show resolved Hide resolved
ocs_ci/ocs/ocp.py Outdated Show resolved Hide resolved
ocs_ci/ocs/ocp.py Outdated Show resolved Hide resolved
ocs_ci/templates/workloads/smallfile/SmallFile.yaml Outdated Show resolved Hide resolved
tests/e2e/performance/test_small_file_workload.py Outdated Show resolved Hide resolved
tests/e2e/performance/test_small_file_workload.py Outdated Show resolved Hide resolved
Avilir added 7 commits May 4, 2020 18:31
@Avilir
Moving OCP related functions from cluster.py to ocp.py
5c28969 
as per @ebenahar suggestion.

Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir
Cleanup of docstings
7825cf7 
Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir
delete empty line - for flake8 compatability
e01bcb8 
Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir
Taking rhe get_ocp_provider function out of the class and change the …
8e80979 
…name of the get_ocp_version to get_ocs_version

Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir
Updating the smallfile yaml template file
9aedc5d 
Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir
Adding numpy to the requirements.txt
7fd00ea 
Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir
Replacing the test analysing with object to analyse results
31b5769 
Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir Avilir changed the title [WIP] Push the smallfile test results into elasticsearch server. Push the smallfile test results into elasticsearch server. May 11, 2020
@vasukulkarni
Copy link
Contributor

Can you schedule a test run in AWS for this test?

vasukulkarni
vasukulkarni reviewed May 11, 2020
View reviewed changes
ocs_ci/ocs/ocp.py Outdated Show resolved Hide resolved
vasukulkarni
vasukulkarni reviewed May 11, 2020
View reviewed changes
ocs_ci/ocs/ocp.py Outdated Show resolved Hide resolved
vasukulkarni
vasukulkarni reviewed May 11, 2020
View reviewed changes
ocs_ci/ocs/ocp.py Outdated Show resolved Hide resolved
@keesturam
Copy link
Member

@Avilir Looks great, Would it be possible to attach the log of sample test run?

@Avilir
Change functions name (remove ocp from the name)
e6eba44 
Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir
Adding UUID to full results output, Changing the calculation of sampl…
fc03477 
…es deviation

Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir
fix merge problem
6f0f949 
Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir
Copy link
Contributor Author

Avilir commented May 12, 2020 •
edited
Loading

@Avilir Looks great, Would it be possible to attach the log of sample test run?

@keesturam

You can find sample results at : here
as you can see the test Failed since in lines 179, 183 and 187 it report on "Error : Deviation < > IOPS is more the 5% ()"

will try to trigger Jenkins job (which probably will fails too)

ocs-ci
ocs-ci reviewed May 12, 2020
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation Job FAILED (installation failed, tests not executed).

@vasukulkarni vasukulkarni mentioned this pull request May 12, 2020
Closed
vasukulkarni
vasukulkarni previously approved these changes May 12, 2020
View reviewed changes
ebenahar
ebenahar reviewed May 14, 2020
View reviewed changes
ocs_ci/ocs/ocp.py Outdated Show resolved Hide resolved
ocs_ci/ocs/ocp.py Outdated Show resolved Hide resolved
tests/e2e/performance/test_small_file_workload.py Outdated Show resolved Hide resolved
tests/e2e/performance/test_small_file_workload.py Show resolved Hide resolved
tests/e2e/performance/test_small_file_workload.py Outdated Show resolved Hide resolved
fbalak
fbalak reviewed May 14, 2020
View reviewed changes
Copy link
Contributor

@fbalak fbalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some docstring suggestions

tests/e2e/performance/test_small_file_workload.py Outdated Show resolved Hide resolved
tests/e2e/performance/test_small_file_workload.py Outdated Show resolved Hide resolved
tests/e2e/performance/test_small_file_workload.py Outdated Show resolved Hide resolved
tests/e2e/performance/test_small_file_workload.py Outdated Show resolved Hide resolved
tests/e2e/performance/test_small_file_workload.py Show resolved Hide resolved
@Avilir
Fixing some doc strings
953c854 
Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir
Adding doc string
2e4227a 
Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir
fixing the way of command writting
007c177 
Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir
Moved the get_provider() function from ocp to node module
f978509 
Signed-off-by: Avi liani <alayani@redhat.com>
@vasukulkarni vasukulkarni merged commit 7958eb8 into red-hat-storage:master May 14, 2020
keesturam pushed a commit to keesturam/ocs-ci that referenced this pull request May 19, 2020
@Avilir @keesturam
Push the smallfile test results into elasticsearch server. (red-hat-s…
9be4d52 
…torage#1984)

* Push the smallfile test results into elasticsearch server.
Results push via ripsaw (snafu) and also with some more information
directly by this test.
Also, increas the number of the samples from 1 to 3.

Signed-off-by: Avi liani <alayani@redhat.com>
@bengland2 bengland2 mentioned this pull request May 19, 2020
Open
@keesturam keesturam mentioned this pull request May 21, 2020
Closed
dahorak pushed a commit to dahorak/ocs-ci that referenced this pull request May 25, 2020
@Avilir @dahorak
Push the smallfile test results into elasticsearch server. (red-hat-s…
f3e1487 
…torage#1984)

* Push the smallfile test results into elasticsearch server.
Results push via ripsaw (snafu) and also with some more information
directly by this test.
Also, increas the number of the samples from 1 to 3.

Signed-off-by: Avi liani <alayani@redhat.com>
@Avilir Avilir deleted the smallfiles-compar branch December 8, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengland2 bengland2 bengland2 left review comments

@AviadP AviadP AviadP left review comments

@ocs-ci ocs-ci ocs-ci left review comments

@vasukulkarni vasukulkarni vasukulkarni approved these changes

@ebenahar ebenahar ebenahar approved these changes

@fbalak fbalak fbalak approved these changes

@keesturam keesturam Awaiting requested review from keesturam

Assignees
No one assigned
Labels
performance size/L PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Avilir @vasukulkarni @keesturam @bengland2 @ebenahar @AviadP @fbalak @ocs-ci