Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuseDom Client Transition error #127

Closed
nampas opened this issue May 4, 2016 · 1 comment
Closed

reuseDom Client Transition error #127

nampas opened this issue May 4, 2016 · 1 comment
Assignees
Labels
bug An issue with the system
Milestone

Comments

@nampas
Copy link
Contributor

nampas commented May 4, 2016

I ran into an issue today with reuseDom, when the destination page has fewer root elements than the source page.

Let's say Page A has 3 root elements, Page B has 1 root element.
When transitioning from from page A to page B via a Client Transition with reuseDom, the 1st root element will get correctly replaced by Page B, but the 2nd and 3rd root elements will remain unchanged (minus CSS) from Page A.

reuseDom needs to wipe out extra root elements when transitioning to a page with fewer Root Elements.

Unfortunately I don't have a good, non-sensitive test case for this.

@gigabo
Copy link
Contributor

gigabo commented May 4, 2016

Nice catch @nampas! Thanks for reporting!

@gigabo gigabo added the bug An issue with the system label May 5, 2016
@gigabo gigabo self-assigned this May 5, 2016
@gigabo gigabo added this to the v0.3.0 milestone May 19, 2016
@gigabo gigabo closed this as completed in 5486e09 May 26, 2016
davidalber pushed a commit to davidalber/react-server that referenced this issue Jul 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the system
Projects
None yet
Development

No branches or pull requests

2 participants