Implement toJson on ReactServerAgent request for logging/debugging #610
Conversation
| queryParams: this._queryParams, | ||
| timeout: this._timeout, | ||
| type: this._type, | ||
| urlPath: this._urlPath, |
There was a problem hiding this comment.
I just slapped everything into the json that I could find on this -- lemme know if I missed anything.
There was a problem hiding this comment.
This LGTM.
@roblg - Do I remember you adding some special handling for this outside of React Server core?
Any conflict here?
There was a problem hiding this comment.
@gigabo It's possible 😁. I don't recall anything though. There's some special handling of ReactServerAgent responses in Cache.js (sibling to Request.js), and there's some special handing of error objects in Redfin-internal code, but I don't think I recall any Request-related handling.
@doug-wade there's also a _cacheWhitelist property (whose name doesn't make any sense unless you look at the implementation) that includes an array of headers that we're interested in from the response. It's technically state on the request; not sure if it's in interesting in a JSON representation of the request.
Somewhat related, are we sure we want to include the raw agent object in a toJSON method? If set, it's a node HTTP Agent, which doesn't really seem JSON-y to me (though maybe it has properties we want to expose?)
There was a problem hiding this comment.
Nice catch @roblg. Gotta get your eyes on more PRs here! 👀
There was a problem hiding this comment.
@roblg Thanks! I've removed _agent and added _cacheWhitelist
doug-wade
changed the title
#228