Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused regular deps: mkdirp, bundle-loader #753

Merged
merged 1 commit into from
Nov 14, 2016

Conversation

roblg
Copy link
Member

@roblg roblg commented Nov 14, 2016

bundle-loader and mkdirp were never actual runtime dependencies of react-server. It looks like us including mkdirp as a runtime dependency probably allowed react-server-integration-tests to work though. 😁

@gigabo
Copy link
Contributor

gigabo commented Nov 14, 2016

Ooh, nice find! Progress toward #277!

@gigabo gigabo merged commit 366d6ab into redfin:master Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants