Front load and cache some page chain class prep #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, no idea why those zombie tests are failing. Everything looks good browser-side in |
emecell
added a commit
to emecell/react-server
that referenced
this pull request
Jan 17, 2018
Relates to redfin#928 but adds in clean up work for the TransitionPage used in tests.
emecell
added a commit
to emecell/react-server
that referenced
this pull request
Jan 17, 2018
Relates to redfin#928 but adds in clean up work for the TransitionPage used in tests.
emecell
added a commit
to emecell/react-server
that referenced
this pull request
Jan 17, 2018
Relates to redfin#928 but adds in clean up work for the TransitionPage used in tests.
This takes some work that used to happen for each request and caches it. This is mostly groundwork for fine-grained instrumentation of page lifecycle methods. It incidentally also slightly reduces the overhead of building up the page chain object during each request. [core/__bench__/handlePage.js](redfin#926) before: ``` 1 0.000481308279135711 10 0.0009405891195623999 100 0.005067864883424908 1000 0.04754033069230767 ``` [core/__bench__/handlePage.js](redfin#926) after: ``` 1 0.0004272630582241284 10 0.0006927164659505115 100 0.0034683026867557273 1000 0.031324801985714294 ``` Basically reduces middleware overhead to from ~50µs to ~30µs. Not a huge deal, but the instrumentation is likely to add a little overhead, so it's nice to pay some of that down ahead of time. 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes some work that used to happen for each request and caches it.
This is mostly groundwork for fine-grained instrumentation of page lifecycle methods. It incidentally also slightly reduces the overhead of building up the page chain object during each request.
core/__bench__/handlePage.jsbefore:core/__bench__/handlePage.jsafter:Basically reduces middleware overhead to from ~50µs to ~30µs. Not a huge deal, but the instrumentation is likely to add a little overhead, so it's nice to pay some of that down ahead of time. 😁