-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: platform parameter is not supported by buildah config (build-without-containerfile) #83
Fix: platform parameter is not supported by buildah config (build-without-containerfile) #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it more clear, can we add this input is not supported for build without containerfile
in action.yml platform
input?
We should make this clearer, yep 👍 Maybe I am picking smalI details, but I wonder if we should flip that around in to a statement about where the parameter is supported: |
Sounds better 👍 |
To save yourself from these types of errors probably you can add git-commit hooks that are present here. |
Sorry, slightly spammy with the commits here, and I realized I forgot to add sign-offs on a few of them. When we are ready I can squash down to a single signed commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this.
…hout-containerfile) Signed-off-by: James Addison <jay@jp-hosting.net>
No problem - apologies for my introducing the problem in the first place! |
Description
The
buildah config
command does not currently support theplatform
parameter.#75 introduced support for
platform
in both build-from-containerfile (which usesbuildah bud
) and build-without-containerfile (which usesbuildah config
).This pull request removes support for
platform
during builds-without-containerfile, and raises an error if the user attempts that.Related Issue(s)
Resolves #82.
Checklist
Changes made
platform
parameter during build-without-containerfile