Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make extension works with node 10 by default #196

Merged
merged 4 commits into from
Oct 3, 2022

Conversation

lstocchi
Copy link
Contributor

@lstocchi lstocchi commented Sep 29, 2022

Followed this guide to migrate to node10 -> https://github.com/microsoft/azure-pipelines-tasks/blob/master/docs/migrateNode10.md

I also bumped the version of each task, so if someone is running with a local agent node6 they are aware of this breaking change.

Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you need to modify the repo settings because seems PR is waiting for a job called Node6 to report

@lstocchi
Copy link
Contributor Author

lstocchi commented Oct 3, 2022

LGTM but you need to modify the repo settings because seems PR is waiting for a job called Node6 to report

I think it's like that because it sees that Node6 workflow in the master but in this PR has been removed. By merging this, the issue should be solved

@lstocchi lstocchi merged commit 8798aa4 into redhat-developer:master Oct 3, 2022
@lstocchi lstocchi deleted the bumpToNode10 branch October 3, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants