Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enum for no-op PauseDetectorWrapper #2474

Closed
mp911de opened this issue Aug 7, 2023 · 0 comments
Closed

Use enum for no-op PauseDetectorWrapper #2474

mp911de opened this issue Aug 7, 2023 · 0 comments
Labels
type: task A general task
Milestone

Comments

@mp911de
Copy link
Collaborator

mp911de commented Aug 7, 2023

To avoid anonymous classes fiddling in Graal Native compilation, we should switch to a named type, ideally an enum.

Error: No instances of io.lettuce.core.metrics.DefaultCommandLatencyCollector$DefaultPauseDetectorWrapper are allowed in the image heap as this class should be initialized at image runtime. To see how this object got instantiated use --trace-object-instantiation=io.lettuce.core.metrics.DefaultCommandLatencyCollector$DefaultPauseDetectorWrapper.
Trace: Object was reached by
  trying to constant fold static field io.lettuce.core.metrics.DefaultCommandLatencyCollector.GLOBAL_PAUSE_DETECTOR
    at io.lettuce.core.metrics.DefaultCommandLatencyCollector.recordCommandLatency(DefaultCommandLatencyCollector.java:109)
  parsing method io.lettuce.core.metrics.DefaultCommandLatencyCollector.recordCommandLatency(DefaultCommandLatencyCollector.java:100) reachable via the parsing context
    at io.lettuce.core.protocol.CommandHandler.recordLatency(CommandHandler.java:914)
    at io.lettuce.core.protocol.CommandHandler.decode(CommandHandler.java:771)
    at io.lettuce.core.protocol.CommandHandler.decode(CommandHandler.java:659)
    at io.lettuce.core.protocol.CommandHandler.channelRead(CommandHandler.java:599)
    at root method.(Unknown Source)
´´´
@mp911de mp911de added the type: task A general task label Aug 7, 2023
@mp911de mp911de added this to the 6.2.6.RELEASE milestone Aug 7, 2023
@mp911de mp911de closed this as completed Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant