Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine command outputs to capture whether a segment has been received instead of relying on the deserialized value state #2498

Closed
mp911de opened this issue Sep 1, 2023 · 0 comments
Labels
type: task A general task
Milestone

Comments

@mp911de
Copy link
Collaborator

mp911de commented Sep 1, 2023

Currently, all command outputs check the decoded value state when decing which segment to read:

if (value == null) {
    value = codec.decodeValue(bytes);
    return;
}

A codec can well decode into a null value effectively destroying the protocol order in which responses are read. It would be better to set a state (e.g. boolean), something along the lines of:

if (!hasValue) {
    value = codec.decodeValue(bytes);
    hasValue = true;
    return;
}
@mp911de mp911de added the type: task A general task label Sep 1, 2023
mp911de added a commit that referenced this issue Sep 1, 2023
… instead of relying on the deserialized value state #2498
mp911de added a commit that referenced this issue Sep 1, 2023
… instead of relying on the deserialized value state #2498
@mp911de mp911de added this to the 6.2.7.RELEASE milestone Sep 1, 2023
@mp911de mp911de closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant