Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced API to allow for extending RedisClusterClient and its connections #1755

Merged
merged 5 commits into from
Jun 21, 2021
Merged

Conversation

jruaux
Copy link
Contributor

@jruaux jruaux commented May 19, 2021

Feature request: #1754

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #1755 (bfbaa8b) into main (31f8635) will increase coverage by 0.00%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1755   +/-   ##
=========================================
  Coverage     78.26%   78.26%           
- Complexity     6731     6735    +4     
=========================================
  Files           508      508           
  Lines         22682    22686    +4     
  Branches       2465     2465           
=========================================
+ Hits          17752    17756    +4     
+ Misses         3781     3779    -2     
- Partials       1149     1151    +2     
Impacted Files Coverage Δ
...va/io/lettuce/core/cluster/MultiNodeExecution.java 54.05% <0.00%> (ø)
.../io/lettuce/core/cluster/PipelinedRedisFuture.java 90.90% <ø> (ø)
...va/io/lettuce/core/cluster/RedisClusterClient.java 87.73% <100.00%> (+0.03%) ⬆️
...re/cluster/StatefulRedisClusterConnectionImpl.java 76.41% <100.00%> (+0.68%) ⬆️
...ce/core/masterreplica/SentinelTopologyRefresh.java 81.93% <0.00%> (-1.30%) ⬇️
src/main/java/io/lettuce/core/RedisPublisher.java 78.01% <0.00%> (-0.93%) ⬇️
...cluster/RedisAdvancedClusterAsyncCommandsImpl.java 87.83% <0.00%> (ø)
...ster/RedisAdvancedClusterReactiveCommandsImpl.java 77.71% <0.00%> (ø)
...java/io/lettuce/core/protocol/DefaultEndpoint.java 70.20% <0.00%> (+0.46%) ⬆️
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 86.95% <0.00%> (+1.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31f8635...bfbaa8b. Read the comment docs.

Copy link
Collaborator

@sokomishalov sokomishalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mp911de
Copy link
Collaborator

mp911de commented Jun 9, 2021

The changes generally look fine. @jruaux do you plan on adding more commits or do you consider this PR complete?

@jruaux
Copy link
Contributor Author

jruaux commented Jun 9, 2021

I don't plan on adding any more commits. The PR is complete.

@mp911de mp911de merged commit 58a81b6 into redis:main Jun 21, 2021
@mp911de mp911de added this to the 6.1.3 milestone Jun 21, 2021
mp911de pushed a commit that referenced this pull request Jun 21, 2021
mp911de added a commit that referenced this pull request Jun 21, 2021
Reformat code. Fix cluster port.

Original pull request: #1755.
mp911de added a commit that referenced this pull request Jun 21, 2021
Reformat code. Fix cluster port.

Original pull request: #1755.
@mp911de
Copy link
Collaborator

mp911de commented Jun 21, 2021

Thank you for your contribution. That's merged, polished, and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants