-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced API to allow for extending RedisClusterClient and its connections #1755
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1755 +/- ##
=========================================
Coverage 78.26% 78.26%
- Complexity 6731 6735 +4
=========================================
Files 508 508
Lines 22682 22686 +4
Branches 2465 2465
=========================================
+ Hits 17752 17756 +4
+ Misses 3781 3779 -2
- Partials 1149 1151 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The changes generally look fine. @jruaux do you plan on adding more commits or do you consider this PR complete? |
I don't plan on adding any more commits. The PR is complete. |
Thank you for your contribution. That's merged, polished, and backported now. |
Feature request: #1754