Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ACL DRYRUN command #1992

Closed
wants to merge 1 commit into from

Conversation

dengliming
Copy link
Collaborator

@dengliming dengliming commented Feb 4, 2022

see https://redis.io/commands/acl-dryrun

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@mp911de mp911de added the type: feature A new feature label Feb 8, 2022
@mp911de mp911de added this to the 6.2.0 milestone Feb 14, 2022
@mp911de
Copy link
Collaborator

mp911de commented Feb 28, 2022

This one might require a bit more thought on whether we want to add it at all. For a simple variant, we should accept arguments as String only without applying value serialization. It could also make sense to accept a Command object for the dry run as we have all details regarding the command structure and encoding in the nested Command object.

@mp911de mp911de added the for: team-attention An issue we need to discuss as a team to make progress label Feb 28, 2022
@mp911de mp911de removed the for: team-attention An issue we need to discuss as a team to make progress label Jul 1, 2022
mp911de pushed a commit that referenced this pull request Jul 1, 2022
mp911de added a commit that referenced this pull request Jul 1, 2022
Allow dry-run using command objects.
@mp911de
Copy link
Collaborator

mp911de commented Jul 1, 2022

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Jul 1, 2022
@dengliming dengliming deleted the feature/acl_dryrun branch July 1, 2022 14:23
mp911de added a commit that referenced this pull request Jul 8, 2022
Use correct command argument count for GET.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants