Fix Set unit test sscanMultiple fail in redis7 #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this pr, `sscanMultiple` will fail at `assertThat(cursor.getCursor()).isNotNull().isNotEqualTo("0");`
This is because the bottom layer is the ListPack structure at this time. It does not support the count option.
It will return all values and set the CURSOR to 0.
see https://redis.io/commands/scan/ *Why SCAN may return all the items of an aggregate data type in a single call?*
for more info.
|
Thank you for your contribution. That's merged and backported now. |
mp911de
pushed a commit
that referenced
this pull request
Apr 18, 2023
Before this pr, `sscanMultiple` will fail at `assertThat(cursor.getCursor()).isNotNull().isNotEqualTo("0");`
This is because the bottom layer is the ListPack structure at this time. It does not support the count option.
It will return all values and set the CURSOR to 0.
see https://redis.io/commands/scan/ *Why SCAN may return all the items of an aggregate data type in a single call?*
for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this pr,
sscanMultiplewill fail atassertThat(cursor.getCursor()).isNotNull().isNotEqualTo("0");, because the bottom layer is the ListPack(set_max_listpack_entries default is 128) structure at this time. It does not support the count option. It will return all values and set the CURSOR to 0.see https://redis.io/commands/scan/ Why SCAN may return all the items of an aggregate data type in a single call? for more info.
This PR also runs successfully on versions prior to 7.0 without incompatibility.
Make sure that: