Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved AbstractCommandSpecProcessor#isSubcommand(ExecutableElement, RoundEnvironment) #1483

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Improved AbstractCommandSpecProcessor#isSubcommand(ExecutableElement, RoundEnvironment) #1483

merged 2 commits into from
Nov 30, 2021

Conversation

rgoldberg
Copy link
Contributor

Improved AbstractCommandSpecProcessor#isSubcommand(ExecutableElement, RoundEnvironment):

Simplified
Improved performance
Fixed possible correctness bug if RoundEnvironment#getElementsAnnotatedWith(Class) ever returns an unmodifiable Set

…ironment):

Simplified
Improved performance
Fixed possible correctness bug if RoundEnvironment#getElementsAnnotatedWith(Class) ever returns an unmodifiable Set
@remkop remkop added this to the 4.6.3 milestone Nov 30, 2021
@remkop remkop added theme: annotation-proc An issue or change related to the annotation processor type: enhancement ✨ labels Nov 30, 2021
@remkop remkop merged commit a8b863c into remkop:master Nov 30, 2021
@remkop
Copy link
Owner

remkop commented Nov 30, 2021

Very nice!
Thank you for the contribution!

(Note to self: TODO update release notes)

@rgoldberg rgoldberg deleted the is-subcommand-improvements branch November 30, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: annotation-proc An issue or change related to the annotation processor type: enhancement ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants