Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subcommand suggestions #2027

Merged
merged 3 commits into from
May 20, 2023
Merged

Subcommand suggestions #2027

merged 3 commits into from
May 20, 2023

Conversation

mauvo
Copy link
Contributor

@mauvo mauvo commented May 19, 2023

Re: #2026

mauvo added 2 commits May 19, 2023 11:34
Still fails due to a deprecation warning related to System::setSecurityManager. Sorry - I'm not familiar enough with Java to know what should be done about it.
@remkop remkop added this to the 4.7.3 milestone May 20, 2023
@remkop remkop added type: enhancement ✨ theme: usagehelp An issue or change related to the usage help message labels May 20, 2023
@remkop remkop removed this from the 4.7.3 milestone May 20, 2023
remkop
remkop previously approved these changes May 20, 2023
Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@remkop
Copy link
Owner

remkop commented May 20, 2023

I do see one failing test:

picocli.UnmatchedArgumentExceptionTest > testUnmatchedArgumentSuggestsSubcommands FAILED
    org.junit.ComparisonFailure at UnmatchedArgumentExceptionTest.java:84

Can you take a look?

@remkop remkop added this to the 4.7.4 milestone May 20, 2023
This time I've actually fixed the tests. Previously I mistook the deprecation warning for the reason the tests failed.
@mauvo
Copy link
Contributor Author

mauvo commented May 20, 2023

Ah yes, I didn't understand the test framework's results. Anyway, it should be fixed now.

@remkop remkop merged commit 4f7898e into remkop:main May 20, 2023
@remkop
Copy link
Owner

remkop commented May 20, 2023

Merged.
Thank you for the contribution!

remkop added a commit that referenced this pull request Jun 3, 2023
remkop added a commit that referenced this pull request Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: usagehelp An issue or change related to the usage help message type: enhancement ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants