Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate resource bundle to subcommands recursively #811

Merged
merged 2 commits into from
Sep 10, 2019

Conversation

frontfact
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 10, 2019

Codecov Report

Merging #811 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #811   +/-   ##
=========================================
  Coverage     93.25%   93.25%           
  Complexity      385      385           
=========================================
  Files             2        2           
  Lines          5704     5704           
  Branches       1484     1484           
=========================================
  Hits           5319     5319           
  Misses          185      185           
  Partials        200      200
Impacted Files Coverage Δ Complexity Δ
src/main/java/picocli/CommandLine.java 92.94% <100%> (ø) 270 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7939003...d05447e. Read the comment docs.

@remkop
Copy link
Owner

remkop commented Sep 10, 2019

Thank you for the pull request! Good catch!
Would it be possible to add a unit test that demonstrates the problem?

@remkop remkop added this to the 4.0.5 milestone Sep 10, 2019
@frontfact
Copy link
Contributor Author

Would it be possible to add a unit test that demonstrates the problem?

I need to fix my Netbeans' JUnit installation first, because for some reason I can't run unit tests for now.

By the way, how does this work: does a new commit in my branch is reflected in this pull request automatically ?

thank you

@remkop
Copy link
Owner

remkop commented Sep 10, 2019

Yes, if you push more commits to the same branch they will show up in this pull request.
Good luck with NetBeans! (Programming is 10% inspiration and 90% getting your environment set up...)

@remkop
Copy link
Owner

remkop commented Sep 10, 2019

I see more commits were added. Thank you!
Please let me know when you’re finished.

@frontfact
Copy link
Contributor Author

I'm finished, let me know if it's not enough or if I missed something, thanks

@remkop remkop merged commit d33c8db into remkop:master Sep 10, 2019
@remkop
Copy link
Owner

remkop commented Sep 10, 2019

Merged into master. Thank you for the contribution!

@frontfact frontfact deleted the resource-bundle-propagation branch September 10, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants