Render with locations #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasche
force-pushed
the
render-with-locations
branch
from
25d0b3f
to
e8925e2
Compare
|
(I rebased this PR now that #49 is merged.) |
rgrinberg
approved these changes
Dec 26, 2020
|
Thanks! Merging now, and rebasing #51. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (on top of #49) is purely an internal refactoring, no user-visible change. Rendering is redefined to work on ASTs with locations, rather than ASTs without locations. The end-goal is to show the location of a template error in error messages, but this requires more work and a restructing of exceptions that would break compatibility -- so I split the easier part in a first PR.