Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally include unique tag in the output path #1053

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Conversation

rhayes777
Copy link
Owner

Resolves #1032

Note that setting the unique_tag will change the identifier

@Jammy2211
Copy link
Collaborator

There is still an issue whereby the unique tag is now being used, but put in the wrong place for the path:

image

The subhalo__sensitivity folder should be in the sensitivity/hello folder, as these results are all part of one pipeline.

The issue is happening on this example script which is faster to run:

https://github.com/Jammy2211/autofit_workspace/blob/release/scripts/features/sensitivity_mapping.py

image

@rhayes777
Copy link
Owner Author

That script had inconsistent path_prefixes, but if those are fixed I think it now works as expected

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.60%. Comparing base (5fda6dc) to head (410a25a).
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
+ Coverage   80.55%   80.60%   +0.04%     
==========================================
  Files         199      199              
  Lines       15298    15305       +7     
==========================================
+ Hits        12324    12336      +12     
+ Misses       2974     2969       -5     
Flag Coverage Δ
80.60% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhayes777 rhayes777 merged commit 121fd96 into main Sep 27, 2024
6 checks passed
@rhayes777 rhayes777 deleted the feature/unique_tag branch September 27, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sensitivity Mapping unique_tag path
2 participants