Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic feedbacks after players have played #1

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add basic feedbacks after players have played #1

wants to merge 8 commits into from

Conversation

dbertella
Copy link

Screen Shot 2020-11-24 at 23 15 02

@riccardobevilacqua riccardobevilacqua added the enhancement New feature or request label Nov 29, 2020
riccardobevilacqua
riccardobevilacqua requested changes Nov 29, 2020
View reviewed changes
Copy link
Owner

@riccardobevilacqua riccardobevilacqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can agree upon removing console.log throughout this PR.

frontend/src/components/Game/Game.tsx Outdated Show resolved Hide resolved
frontend/src/components/Game/Game.tsx Outdated Show resolved Hide resolved
frontend/src/components/Game/Game.tsx Outdated Show resolved Hide resolved
frontend/src/components/Game/Game.tsx Outdated Show resolved Hide resolved
frontend/src/components/Game/Game.tsx Outdated Show resolved Hide resolved
frontend/src/components/Game/Game.tsx Outdated Show resolved Hide resolved
frontend/src/components/MoveSelector/MoveSelector.tsx Outdated Show resolved Hide resolved
@dbertella
Copy link
Author

I think we can agree upon removing console.log throughout this PR.

Yes you are right, I left it there just because this was unfinished, I didn't think you would merge it as it is. For example we can display images instead of plain text. Anyway I will remove them you are right

dbertella and others added 7 commits November 29, 2020 14:43
@dbertella @riccardobevilacqua
Update frontend/src/components/MoveSelector/MoveSelector.tsx
50bedbe 
Co-authored-by: Riccardo Bevilacqua <bevilacqua.riccardo@gmail.com>
@dbertella @riccardobevilacqua
Update frontend/src/components/Game/Game.tsx
2b420e7 
Co-authored-by: Riccardo Bevilacqua <bevilacqua.riccardo@gmail.com>
@dbertella @riccardobevilacqua
Update frontend/src/components/Game/Game.tsx
21fe097 
Co-authored-by: Riccardo Bevilacqua <bevilacqua.riccardo@gmail.com>
@dbertella @riccardobevilacqua
Update frontend/src/components/Game/Game.tsx
c9c6342 
Co-authored-by: Riccardo Bevilacqua <bevilacqua.riccardo@gmail.com>
@dbertella @riccardobevilacqua
Update frontend/src/components/Game/Game.tsx
933f026 
Co-authored-by: Riccardo Bevilacqua <bevilacqua.riccardo@gmail.com>
@dbertella @riccardobevilacqua
Update frontend/src/components/Game/Game.tsx
7845710 
Co-authored-by: Riccardo Bevilacqua <bevilacqua.riccardo@gmail.com>
@dbertella @riccardobevilacqua
Update frontend/src/components/Game/Game.tsx
d952370 
Co-authored-by: Riccardo Bevilacqua <bevilacqua.riccardo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardobevilacqua riccardobevilacqua riccardobevilacqua requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbertella @riccardobevilacqua