Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: go mod ambiguous imports #277

Merged
merged 3 commits into from
Oct 17, 2023
Merged

fix: go mod ambiguous imports #277

merged 3 commits into from
Oct 17, 2023

Conversation

fredmaggiowski
Copy link
Member

This PR fixes module issues due to ugorji/go#299 and https://github.com/perimeterx/marshmallow using it

@fredmaggiowski fredmaggiowski added dependencies Pull requests that update a dependency file security Anything security related and removed security Anything security related labels Oct 17, 2023
@github-actions
Copy link

Pull Request Test Coverage Report for Build 6543765793

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.744%
Totals Coverage Status
Change from base Build 6510745954: 0.0%
Covered Lines: 2072
Relevant Lines: 2445
💛 - Coveralls

davidebianchi
davidebianchi reviewed Oct 17, 2023
View reviewed changes
service/router.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Oct 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6543992234

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.744%
Totals Coverage Status
Change from base Build 6543980283: 0.0%
Covered Lines: 2072
Relevant Lines: 2445
💛 - Coveralls

@fredmaggiowski fredmaggiowski merged commit 298eaf2 into main Oct 17, 2023
7 checks passed
@fredmaggiowski fredmaggiowski deleted the fix/go-mod-ambiguous-imports branch October 17, 2023 07:41
@fredmaggiowski fredmaggiowski added the bug Something isn't working label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidebianchi davidebianchi davidebianchi left review comments

Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredmaggiowski @coveralls @davidebianchi